-
-
Notifications
You must be signed in to change notification settings - Fork 221
Add childprotection module #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like the necessary data was available in the sysinfo after all, so there's no need to poll the child device for that, and this should be good to go. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1141 +/- ##
==========================================
+ Coverage 92.55% 92.57% +0.01%
==========================================
Files 100 101 +1
Lines 6607 6624 +17
Branches 708 708
==========================================
+ Hits 6115 6132 +17
Misses 370 370
Partials 122 122 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits. I think for consistency use self.data
. Testing the setter is your call.
## [0.7.7](https://github.com/python-kasa/python-kasa/tree/0.7.7) (2024-11-04) [Full Changelog](0.7.6...0.7.7) **Release summary:** - Bugfix for child device device creation error with credentials_hash - PIR support for iot dimmers and wall switches. - Various small enhancements and project improvements. **Implemented enhancements:** - Add PIR&LAS for wall switches mentioning PIR support [\#1227](#1227) (@rytilahti) - Expose ambient light setting for iot dimmers [\#1210](#1210) (@rytilahti) - Expose PIR enabled setting for iot dimmers [\#1174](#1174) (@rytilahti) - Add childprotection module [\#1141](#1141) (@rytilahti) - Initial trigger logs implementation [\#900](#900) (@rytilahti) **Fixed bugs:** - Fix AES child device creation error [\#1220](#1220) (@sdb9696) **Project maintenance:** - Update TC65 fixture [\#1225](#1225) (@rytilahti) - Update smartcamera fixtures from latest dump\_devinfo [\#1224](#1224) (@sdb9696) - Add component queries to smartcamera devices [\#1223](#1223) (@sdb9696) - Update try\_connect\_all to be more efficient and report attempts [\#1222](#1222) (@sdb9696) - Use stacklevel=2 for warnings to report on callsites [\#1219](#1219) (@rytilahti) - parse\_pcap\_klap: various code cleanups [\#1138](#1138) (@rytilahti)
When turned on, rotating the thermostat will not change the target temperature.