Stabilise on_since value for smart devices #1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1144 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 96 96
Lines 6104 6119 +15
Branches 1512 1514 +2
=======================================
+ Hits 5652 5666 +14
Misses 354 354
- Partials 98 99 +1 ☔ View full report in Codecov by Sentry. |
rytilahti
reviewed
Oct 1, 2024
rytilahti
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Just a minor nit on the docstring wording, but otherwise this looks good!
I have been running this now for four hours (checking on an iot device though, so please update the PR title), with four changes on the current homeassistant vs. none when using this PR.
Merged
sdb9696
added a commit
that referenced
this pull request
Oct 8, 2024
## [0.7.5](https://github.com/python-kasa/python-kasa/tree/0.7.5) (2024-10-08) [Full Changelog](0.7.4...0.7.5) **Release summary:** - Fix for KP303 on Firmware 1.0.6 - Fix for `on_since` value jitter - Various maintenance items **Breaking changes:** - Make iot time timezone aware [\#1147](#1147) (@sdb9696) **Fixed bugs:** - Use tzinfo in time constructor instead of astime for iot devices [\#1158](#1158) (@sdb9696) - Send empty dictionary instead of null for iot queries [\#1145](#1145) (@sdb9696) - Stabilise on\_since value for smart devices [\#1144](#1144) (@sdb9696) - parse\_pcap\_klap: require source host [\#1137](#1137) (@rytilahti) - parse\_pcap\_klap: use request\_uri for matching the response [\#1136](#1136) (@rytilahti) **Project maintenance:** - Cache zoneinfo for smart devices [\#1156](#1156) (@sdb9696) - Correctly define SmartModule.call as an async function [\#1148](#1148) (@sdb9696) - Remove async magic patch from tests [\#1146](#1146) (@sdb9696) - Move feature initialization from \_\_init\_\_ to \_initialize\_features [\#1140](#1140) (@rytilahti)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address HA issue 126852.
It's difficult to know for certain how many seconds to set this to but I suspect the variation is just 1 second.