Skip to content

Expose ambient light setting for iot dimmers #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

rytilahti
Copy link
Member

This PR adds a setting to control the ambient light enabled/disabled.

Also fixes the getters, related to #1174

@rytilahti rytilahti added the enhancement New feature or request label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.60%. Comparing base (9975bbf) to head (d3b43d0).
Report is 208 commits behind head on master.

Files with missing lines Patch % Lines
kasa/iot/modules/ambientlight.py 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
+ Coverage   92.56%   92.60%   +0.04%     
==========================================
  Files          99       99              
  Lines        6548     6558      +10     
  Branches      702      703       +1     
==========================================
+ Hits         6061     6073      +12     
+ Misses        367      364       -3     
- Partials      120      121       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti changed the title Add feature to toggle dimmer ambient light setting Expose ambient light setting for iot dimmers Oct 30, 2024
@rytilahti rytilahti force-pushed the feat/ambient_light_enabled_feature branch from f848630 to c8d37dc Compare October 30, 2024 13:37
@rytilahti
Copy link
Member Author

Added tests, this is now based on #1174 which should be merged before rebasing & merging this one.

@rytilahti rytilahti force-pushed the feat/ambient_light_enabled_feature branch from 51d60c0 to d3b43d0 Compare October 31, 2024 10:43
@rytilahti rytilahti requested a review from sdb9696 October 31, 2024 10:43
Copy link
Collaborator

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rytilahti rytilahti merged commit 6c141c3 into master Oct 31, 2024
27 of 28 checks passed
@rytilahti rytilahti deleted the feat/ambient_light_enabled_feature branch October 31, 2024 11:17
@sdb9696 sdb9696 added this to the 0.7.7 milestone Nov 4, 2024
@sdb9696 sdb9696 mentioned this pull request Nov 4, 2024
sdb9696 added a commit that referenced this pull request Nov 4, 2024
## [0.7.7](https://github.com/python-kasa/python-kasa/tree/0.7.7) (2024-11-04)

[Full Changelog](0.7.6...0.7.7)

**Release summary:**

- Bugfix for child device device creation error with credentials_hash
- PIR support for iot dimmers and wall switches.
- Various small enhancements and project improvements.

**Implemented enhancements:**

- Add PIR&LAS for wall switches mentioning PIR support [\#1227](#1227) (@rytilahti)
- Expose ambient light setting for iot dimmers [\#1210](#1210) (@rytilahti)
- Expose PIR enabled setting for iot dimmers [\#1174](#1174) (@rytilahti)
- Add childprotection module [\#1141](#1141) (@rytilahti)
- Initial trigger logs implementation [\#900](#900) (@rytilahti)

**Fixed bugs:**

- Fix AES child device creation error [\#1220](#1220) (@sdb9696)

**Project maintenance:**

- Update TC65 fixture [\#1225](#1225) (@rytilahti)
- Update smartcamera fixtures from latest dump\_devinfo [\#1224](#1224) (@sdb9696)
- Add component queries to smartcamera devices [\#1223](#1223) (@sdb9696)
- Update try\_connect\_all to be more efficient and report attempts [\#1222](#1222) (@sdb9696)
- Use stacklevel=2 for warnings to report on callsites [\#1219](#1219) (@rytilahti)
- parse\_pcap\_klap: various code cleanups [\#1138](#1138) (@rytilahti)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants