Skip to content

Add turnonbehaviormodule for iot #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add turnonbehaviormodule for iot #1288

wants to merge 1 commit into from

Conversation

rytilahti
Copy link
Member

A draft PR used for testing #1285.

== Configuration ==
Turn on hard (turn_on_hard): *BehaviorMode.Last* customize_preset circadian
Turn on soft (turn_on_soft): *BehaviorMode.Last* customize_preset circadian

@rytilahti rytilahti changed the title Migrate TurnOnBehaviours to mashumaro Add turnonbehaviormodule for iot Nov 20, 2024
@rytilahti rytilahti mentioned this pull request Nov 20, 2024
Merged
@rytilahti rytilahti force-pushed the feat/iotbulb_turnonbehavior branch from dbefbe8 to de8710b Compare November 20, 2024 14:36
rytilahti
rytilahti commented Nov 20, 2024
View reviewed changes
kasa/iot/iotbulb.py
@@ -222,6 +168,10 @@ async def _initialize_modules(self) -> None:
Module.IotAntitheft, Antitheft(self, "smartlife.iot.common.anti_theft")
)
self.add_module(Module.Time, Time(self, "smartlife.iot.common.timesetting"))
self.add_module(
Module.IotTurnOnBehavior,
TurnOnBehaviorModule(self, "smartlife.iot.smartbulb.lightingservice"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Named as Module, as TurnOnBehavior is already taken by the model... We probably want to make a breaking change here, and rename the models to something else.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Feb 19, 2025
@rytilahti rytilahti added no-stale and removed stale labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rytilahti