Add fixture for RV30 Plus #1323
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytilahti
commented
Nov 30, 2024
Comment on lines
+850
to
+851
| # Vacuum models can have a space in their name | ||
| model = model_info.long_name.replace(" ", "_") |
There was a problem hiding this comment.
This might break some filename parsing elsewhere, but hopefully not.. :-)
| @@ -124,6 +124,7 @@ | |||
| HUBS_SMART = {"H100", "KH100"} | |||
| SENSORS_SMART = {"T310", "T315", "T300", "T100", "T110", "S200B", "S200D"} | |||
| THERMOSTATS_SMART = {"KE100"} | |||
| VACUUMS_SMART = {"RV30"} | |||
There was a problem hiding this comment.
Use the prefix, or the full name? There exist different RV30 versions in different markets, so it might be necessary to make this more strict later.
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First vacuum fixture file, the tests won't pass until later but it's a good start.
Thanks to @steveredden for the fixture.
Dumped with #1322, related to #943 and to #937.