Skip to content

Add more vacuum requests #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add more vacuum requests #1331

wants to merge 1 commit into from

Conversation

rytilahti
Copy link
Member

Add more requests from #937.

@rytilahti rytilahti added the maintenance Project improvements and maintenance label Dec 2, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.20%. Comparing base (74b59d7) to head (d32aa5e).
Report is 133 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1331   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files         120      120           
  Lines        7744     7744           
  Branches      805      805           
=======================================
  Hits         7140     7140           
  Misses        444      444           
  Partials      160      160

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sdb9696
sdb9696 reviewed Dec 2, 2024
View reviewed changes
devtools/helpers/smartrequests.py
@@ -33,6 +33,35 @@
_LOGGER = logging.getLogger(__name__)


@dataclass
class SmartRequestParams:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this pr move the SmartRequestParams out of the SmartRequest class, but only for the GetCleanAttrParams and GetMapDataParams?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to use raw SmartRequestParams to avoid defining new classes, but it didn't work so I added the classes. I will move it back later.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Mar 3, 2025
@sdb9696 sdb9696 added no-stale and removed stale labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdb9696 sdb9696 sdb9696 left review comments

Assignees
No one assigned
Labels
maintenance Project improvements and maintenance no-stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rytilahti @sdb9696