Skip to content

Fix update errors on hubs with unsupported children #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented Dec 6, 2024

Fixes issue mentioned in comments in issue #1341 (comment)

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.12%. Comparing base (8814d94) to head (bccb501).
Report is 131 commits behind head on master.

Files with missing lines Patch % Lines
kasa/smart/smartdevice.py 40.00% 2 Missing and 1 partial ⚠️
kasa/smartcam/smartcamdevice.py 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
- Coverage   92.18%   92.12%   -0.06%     
==========================================
  Files         120      120              
  Lines        7751     7759       +8     
  Branches      805      807       +2     
==========================================
+ Hits         7145     7148       +3     
- Misses        445      448       +3     
- Partials      161      163       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sdb9696 sdb9696 added this to the 0.8.1 milestone Dec 6, 2024
@sdb9696 sdb9696 added the bug Something isn't working label Dec 6, 2024
@sdb9696 sdb9696 changed the title Fix update errors on hubs with child smartcams Fix update errors on smartcam hubs with unsupported child devices Dec 6, 2024
@sdb9696 sdb9696 changed the title Fix update errors on smartcam hubs with unsupported child devices Fix update errors on smartcam hubs with unsupported children Dec 6, 2024
@sdb9696 sdb9696 changed the title Fix update errors on smartcam hubs with unsupported children Fix update errors on hubs with unsupported children Dec 6, 2024
@sdb9696 sdb9696 merged commit be8b713 into master Dec 6, 2024
15 of 17 checks passed
@sdb9696 sdb9696 deleted the fix/child_smartcam branch December 6, 2024 11:01
@sdb9696 sdb9696 mentioned this pull request Dec 6, 2024
sdb9696 added a commit that referenced this pull request Dec 6, 2024
## [0.8.1](https://github.com/python-kasa/python-kasa/tree/0.8.1) (2024-12-06)

This patch release fixes some issues with newly supported smartcam devices.

[Full Changelog](0.8.0...0.8.1)

**Fixed bugs:**

- Fix update errors on hubs with unsupported children [\#1344](#1344) (@sdb9696)
- Fix smartcam missing device id [\#1343](#1343) (@sdb9696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants