Improve exception messages on credential mismatches #1417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1417 +/- ##
=======================================
Coverage 92.52% 92.52%
=======================================
Files 132 132
Lines 8251 8251
Branches 848 848
=======================================
Hits 7634 7634
Misses 453 453
Partials 164 164 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
19 tasks
sdb9696
approved these changes
Jan 4, 2025
Merged
sdb9696
added a commit
that referenced
this pull request
Jan 6, 2025
## [0.9.1](https://github.com/python-kasa/python-kasa/tree/0.9.1) (2025-01-06) [Full Changelog](0.9.0...0.9.1) **Release summary:** - Support for hub-attached wall switches S210 and S220 - Support for older firmware on Tapo cameras - Bugfixes and improvements **Implemented enhancements:** - Add support for Tapo hub-attached switch devices [\#1421](#1421) (@sdb9696) - Use repr\(\) for enum values in Feature.\_\_repr\_\_ [\#1414](#1414) (@rytilahti) - Update SslAesTransport for older firmware versions [\#1362](#1362) (@sdb9696) **Fixed bugs:** - T310 not detected with H200 Hub [\#1409](#1409) - Backoff after xor timeout and improve error reporting [\#1424](#1424) (@bdraco) - Fix incorrect obd src echo [\#1412](#1412) (@rytilahti) - Handle smartcam partial list responses [\#1411](#1411) (@sdb9696) **Added support for devices:** - Add S220 fixture [\#1419](#1419) (@rytilahti) - Add S210 fixture [\#1418](#1418) (@rytilahti) **Documentation updates:** - Improve exception messages on credential mismatches [\#1417](#1417) (@rytilahti) **Project maintenance:** - Add C210 2.0 1.3.11 fixture [\#1406](#1406) (@sdb9696) - Add HS210\(US\) 3.0 1.0.10 IOT Fixture [\#1405](#1405) (@ZeliardM) - Change smartcam detection features to category config [\#1402](#1402) (@sdb9696)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the exception message on authentication hash mismatches clearer.
I renamed "server" to "device" as that makes more sense for errors that are shown to users.
Related comments:
Thanks to @TheHairforce and @ZeliardM for helping spot the issue, I will create a separate PR to update the exception messages to help users encountering the challenge hash mismatch.