Make uses_http a readonly property of device config #1449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1449 +/- ##
==========================================
+ Coverage 92.55% 92.56% +0.01%
==========================================
Files 133 133
Lines 8336 8344 +8
Branches 857 860 +3
==========================================
+ Hits 7715 7724 +9
+ Misses 455 454 -1
Partials 166 166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rytilahti
approved these changes
Jan 14, 2025
|
That's done |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses_httpis not supposed to be set by consumers. For historical reasons it was a dataclass field so that HomeAssistant could persist and re-use the config dict. This is no longer the case as HA stores theuses_httpfrom theDeviceConfigdirectly.Making
uses_httpa readonly property simplifies the logic intry_connect_all. This PR also fixestry_connect_allto includeSMART.TAPOROBOVACandIOT.IPCAMERAas main device types.Breaking info - consumers that relied on
uses_httpto be persisted withDeviceConfig.to_dict()will need to store the value separately.