Skip to content

Add some of my device fixtures, KL430 is for #439 #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add some of my device fixtures, KL430 is for #439 #441

wants to merge 1 commit into from

Conversation

jimboca
Copy link
Contributor

@jimboca jimboca commented Mar 19, 2023

Let me know if it makes sense that the KL430 is causing my issue in #439

@jimboca
Copy link
Contributor Author

jimboca commented Mar 19, 2023

Looks like that KL430 does cause the failure.

@jimboca jimboca mentioned this pull request Mar 30, 2023
Closed
@rytilahti
Copy link
Member

Thanks for these! Let's wait before merging this that #440 gets done to avoid breaking the CI.

@rytilahti rytilahti mentioned this pull request Mar 30, 2023
Merged
@rytilahti
Copy link
Member

@jimboca I merged the fix, but couldn't rebase nor fix the tests for this PR. Would you mind allowing me to edit this PR to do the changes?

@jimboca
Copy link
Contributor Author

jimboca commented Apr 1, 2023

@jimboca I merged the fix, but couldn't rebase nor fix the tests for this PR. Would you mind allowing me to edit this PR to do the changes?

I looked and it is on?
image
But I also gave you permission on my Fork if that helps?

@rytilahti rytilahti mentioned this pull request Jun 3, 2024
Merged
@rytilahti
Copy link
Member

Sorry @jimboca, this somehow slipped through the cracks. I fixed the conflicts, but wasn't able to push on your branch (perhaps because it's master), so I just cherry-picked your commit & created a new PR (#948).

Thanks again!

@rytilahti rytilahti closed this Jun 3, 2024
rytilahti added a commit that referenced this pull request Jun 4, 2024
@rytilahti @jimboca @sdb9696
Add some device fixtures (#948)
40f2263 
Adds some device fixtures by courtesy of @jimboca, thanks!
This is a slightly patched and rebased version of #441.

---------

Co-authored-by: JimBo <jimboca3@gmail.com>
Co-authored-by: sdb9696 <steven.beth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimboca @rytilahti