Replace asyncio.wait_for with async-timeout #480
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #480 +/- ##
==========================================
+ Coverage 79.55% 79.61% +0.06%
==========================================
Files 26 26
Lines 1956 1962 +6
Branches 599 602 +3
==========================================
+ Hits 1556 1562 +6
Misses 359 359
Partials 41 41
☔ View full report in Codecov by Sentry. |
Fallback to using async_timeout on older python asyncio.wait_for has some underlying problems that are only fixed in cpython 3.12. See python/cpython#98518
Fallback to using async_timeout on older python asyncio.wait_for has some underlying problems that are only fixed in cpython 3.12. See python/cpython#98518
|
How crucial it is to get this released rather sooner than later? Currently a bit busy with other things, so if a new release can wait I'd rather do it later. |
|
It's hard to tell from the information users have provided if they have network problems or are getting hitting by races with wait_for which makes it difficult to give a good answer here. I suspect we have both cases. It would be great to have it released in time for beta on Wednesday. |
|
Potentially related to home-assistant/core#90636 |
Note: CI failure is fixed by #482
asyncio.wait_forhas some underlying problems that are only fixed in cpython 3.12.Use
async_timeoutinstead until the minimum supported version is 3.11+ and it can be replaced withasyncio.timeoutSee python/cpython#98518