-
-
Notifications
You must be signed in to change notification settings - Fork 221
Add EP25 smart fixture and improve test framework for SMART devices #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #572 +/- ##
=======================================
Coverage 79.56% 79.56%
=======================================
Files 37 37
Lines 3083 3083
Branches 804 804
=======================================
Hits 2453 2453
Misses 548 548
Partials 82 82 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more, the merrier! Could you add the model to the README file, too?
c43c55f
to
c5b81b1
Compare
So I've added the model to the README but while doing so I noticed that #567 had tripped up over the partially implemented splitting out of So to get ahead of any future confusion I've updated the PR to:
|
c5b81b1
to
a46b862
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
a46b862
to
6ad7de4
Compare
This PR adds further updates to the test framework to handle the new TAPO/SMART devices and includes the EP25 smart fixture: