Skip to content

Add optional error code to exceptions #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented Dec 20, 2023

Broken out from #584

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6819c74) 84.78% compared to head (74f7140) 84.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
+ Coverage   84.78%   84.82%   +0.04%     
==========================================
  Files          37       37              
  Lines        3220     3230      +10     
  Branches      810      810              
==========================================
+ Hits         2730     2740      +10     
  Misses        413      413              
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward to me. We will want to document this and other new changes in the docs, but that can wait for now.

@rytilahti rytilahti merged commit b663471 into python-kasa:master Dec 20, 2023
@sdb9696 sdb9696 deleted the errorcode_to_exceptions branch February 20, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants