Implement wifi interface for tapodevice #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested to work on P110
1dadc4e to
8433b26
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #606 +/- ##
==========================================
- Coverage 85.30% 84.76% -0.54%
==========================================
Files 38 38
Lines 3381 3406 +25
Branches 852 857 +5
==========================================
+ Hits 2884 2887 +3
- Misses 418 440 +22
Partials 79 79 ☔ View full report in Codecov by Sentry. |
|
@sdb9696 would you mind testing that the wifi scanning is also working for you? We will refactor this later into its own module and add tests, but this could also go into the alpha release. |
|
Sure, will try this out tomorrow. |
|
Ok, I don't think there will be any issues so I'll merge this and prepare the release already tonight 👍 |
|
I tested this earlier today and it seemed to work fine. I couldn't be 100% sure of the join as I only have one 2G network which it was already on but no errors and the scan worked fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
wifi_scanandwifi_joinfor SMART devices, allows to change the wifi settings using the cli.This maybe helpful for #565 if some of those known hardcoded creds work for non-provisioned setups.
Tested to work on P110.