Skip to content

Add smartdevice module for smooth transitions #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Add smartdevice module for smooth transitions #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66ceed6
Add smart module for smooth transitions
rytilahti Feb 16, 2024
e1e02c4
Fix tests
rytilahti Feb 19, 2024
6c6c6fa
Fix linting
rytilahti Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion kasa/smart/modules/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
from .childdevicemodule import ChildDeviceModule
from .devicemodule import DeviceModule
from .energymodule import EnergyModule
from .lighttransitionmodule import LightTransitionModule
from .timemodule import TimeModule

__all__ = ["TimeModule", "EnergyModule", "DeviceModule", "ChildDeviceModule"]
__all__ = [
"TimeModule",
"EnergyModule",
"DeviceModule",
"ChildDeviceModule",
"LightTransitionModule",
]
41 changes: 41 additions & 0 deletions kasa/smart/modules/lighttransitionmodule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
"""Module for smooth light transitions."""
from typing import TYPE_CHECKING

from ...feature import Feature, FeatureType
from ..smartmodule import SmartModule

if TYPE_CHECKING:
from ..smartdevice import SmartDevice


class LightTransitionModule(SmartModule):
"""Implementation of gradual on/off."""

REQUIRED_COMPONENT = "on_off_gradually"
QUERY_GETTER_NAME = "get_on_off_gradually_info"

def __init__(self, device: "SmartDevice", module: str):
super().__init__(device, module)
self._add_feature(
Feature(
device=device,
container=self,
name="Smooth transitions",
icon="mdi:transition",
attribute_getter="enabled",
attribute_setter="set_enabled",
type=FeatureType.Switch,
)
)

def set_enabled(self, enable: bool):
"""Enable gradual on/off."""
return self.call("set_on_off_gradually_info", {"enable": enable})

@property
def enabled(self) -> bool:
"""Return True if gradual on/off is enabled."""
return bool(self.data["enable"])

def __cli_output__(self):
return f"Gradual on/off enabled: {self.enabled}"
1 change: 1 addition & 0 deletions kasa/smart/smartdevice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
ChildDeviceModule,
DeviceModule,
EnergyModule,
LightTransitionModule,
TimeModule,
)
from .smartmodule import SmartModule
Expand Down
1 change: 1 addition & 0 deletions kasa/tests/fakeprotocol_smart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ def credentials_hash(self):

FIXTURE_MISSING_MAP = {
"get_wireless_scan_info": ("wireless", {"ap_list": [], "wep_supported": False}),
"get_on_off_gradually_info": ("on_off_gradually", {"enable": True}),
}

async def send(self, request: str):
Expand Down