-
-
Notifications
You must be signed in to change notification settings - Fork 221
Add hass_compat to feature #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This improves the temperature control features to allow implementing climate platform support for homeassistant Also adds frostprotection module, which is basically also used to turn the thermostat on and off.
It would be good to close out the open question here from @bdraco home-assistant/core#111151 (comment). It might be helpful to list some of the things/scenarios we're currently unable to derive in HA. For example I thought it was going to be sufficient to use the For the DeviceClass and StateClass it does seem to suggest a lot of HA development knowledge when creating a feature as to how these are all treated in HA. Maybe we could maintain a set of |
c2f8cbb
to
6d12158
Compare
I commented on that thread on this, but I agree that we should not proceed with this approach, but leave it to the homeassistant integration to do the mapping. Some of this can be done automatically, but for some we are going to need a mapping inside homeassistant. At least for those that require manual mapping, we are going to need to set the The difference between hiding & disabling is that the disabled entities won't be added to the state machine at all, but hidden ones are not added to the panes like the dashboard automatically. If you take a look at the screenshots in the description, you see that not all sensors (mainly the historical emeter ones) are not added, even when they are shown in the device page and recorded as expected. On categorization, we could use the This would make us have the following categorization rules: |
Or we set the id if/when we change the naming?
Yes, I think this is simplest and we can always use overrides in HA if necessary.
Agreed. Then in HA we have a mapping of feature ids > (device_class, state_class) etc. The mappings can presumably live in each of the entity files as different entities have different description values. |
I think we should do this from the get-go, as it will also allow us to use the the ids as translation keys.
Okay, I'll proceed to create a new PR that updates the categorization to follow this plan.
Makes sense to me, thanks for your input! 👍 |
Replaced with #904. |
This adds
hass_compat
(name suggestions welcome!) that allows defining extra attributes to homeassistant's *entitydescriptions for better and cleaner UX. At the moment this is just converted to dict and passed directly to *entitydescriptions.This is based on #872 which needs to be merged first.
Fixes #842