Skip to content

Initial trigger logs implementation #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Conversation

rytilahti
Copy link
Member

No description provided.

@rytilahti rytilahti added the enhancement New feature or request label May 4, 2024
Copy link
Collaborator

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. Maybe the child device errors should go into 0.7.0 in a separate PR if we don't think we'll get tests for this in time.

@rytilahti
Copy link
Member Author

Yes, I was about to write that we probably only want the error handling piece in as a separate PR, as it will also fix the issue when one tries to command a device with out-of-sync time. I'll separate it from the trigger log implementation & leave the update children also out, as that's something which will require some more thought and testing anyway.

@rytilahti rytilahti force-pushed the feat/implement_triggerlogs branch from b26fd2f to ff608e6 Compare October 18, 2024 11:57
@rytilahti rytilahti changed the base branch from feat/hub_pairing to master October 18, 2024 11:58
@rytilahti
Copy link
Member Author

Rebased on top of the current master (instead of previous hub pairing PR).

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.55%. Comparing base (7335a7d) to head (550610d).
Report is 206 commits behind head on master.

Files with missing lines Patch % Lines
kasa/cli/device.py 42.85% 4 Missing ⚠️
kasa/smart/modules/triggerlogs.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
- Coverage   92.60%   92.55%   -0.05%     
==========================================
  Files          99      100       +1     
  Lines        6558     6584      +26     
  Branches      703      705       +2     
==========================================
+ Hits         6073     6094      +21     
- Misses        364      369       +5     
  Partials      121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdb9696 sdb9696 marked this pull request as ready for review November 1, 2024 15:35
@sdb9696 sdb9696 merged commit 70c96b5 into master Nov 1, 2024
26 of 28 checks passed
@sdb9696 sdb9696 deleted the feat/implement_triggerlogs branch November 1, 2024 15:36
@sdb9696 sdb9696 added this to the 0.7.7 milestone Nov 4, 2024
@sdb9696 sdb9696 mentioned this pull request Nov 4, 2024
sdb9696 added a commit that referenced this pull request Nov 4, 2024
## [0.7.7](https://github.com/python-kasa/python-kasa/tree/0.7.7) (2024-11-04)

[Full Changelog](0.7.6...0.7.7)

**Release summary:**

- Bugfix for child device device creation error with credentials_hash
- PIR support for iot dimmers and wall switches.
- Various small enhancements and project improvements.

**Implemented enhancements:**

- Add PIR&LAS for wall switches mentioning PIR support [\#1227](#1227) (@rytilahti)
- Expose ambient light setting for iot dimmers [\#1210](#1210) (@rytilahti)
- Expose PIR enabled setting for iot dimmers [\#1174](#1174) (@rytilahti)
- Add childprotection module [\#1141](#1141) (@rytilahti)
- Initial trigger logs implementation [\#900](#900) (@rytilahti)

**Fixed bugs:**

- Fix AES child device creation error [\#1220](#1220) (@sdb9696)

**Project maintenance:**

- Update TC65 fixture [\#1225](#1225) (@rytilahti)
- Update smartcamera fixtures from latest dump\_devinfo [\#1224](#1224) (@sdb9696)
- Add component queries to smartcamera devices [\#1223](#1223) (@sdb9696)
- Update try\_connect\_all to be more efficient and report attempts [\#1222](#1222) (@sdb9696)
- Use stacklevel=2 for warnings to report on callsites [\#1219](#1219) (@rytilahti)
- parse\_pcap\_klap: various code cleanups [\#1138](#1138) (@rytilahti)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants