Skip to content

Add generic typing support to features #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented May 21, 2024

No description provided.

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.49%. Comparing base (5e619af) to head (a3a5c5d).
Report is 346 commits behind head on master.

Files with missing lines Patch % Lines
kasa/feature.py 94.28% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   91.47%   91.49%   +0.01%     
==========================================
  Files          83       83              
  Lines        5434     5466      +32     
  Branches     1316     1317       +1     
==========================================
+ Hits         4971     5001      +30     
- Misses        362      363       +1     
- Partials      101      102       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdb9696 sdb9696 mentioned this pull request May 23, 2024
@sdb9696 sdb9696 marked this pull request as draft July 4, 2024 12:34
@sdb9696
Copy link
Collaborator Author

sdb9696 commented Sep 27, 2024

Closing for now as not too pressing, can always revisit.

@sdb9696 sdb9696 closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant