Skip to content

Codecov reports spurious coverage changes #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
encukou opened this issue Dec 13, 2017 · 0 comments
Closed

Codecov reports spurious coverage changes #127

encukou opened this issue Dec 13, 2017 · 0 comments

Comments

@encukou
Copy link
Member

encukou commented Dec 13, 2017

Retry logic in _slapdtest is triggered randomly, leading to spurious reports.
Example for a doc-only change: https://codecov.io/gh/python-ldap/python-ldap/pull/115/changes for #115
tiran added a commit to tiran/python-ldap that referenced this issue Dec 13, 2017
@tiran
Add pragma: no cover to avoid spurious cov changes
7c4cee9 
"pragma: no cover" was added to two helper functions in slapdtest to
avoid spurious changes in coverage whenever slapd has a hick up.

Closes: python-ldap#127
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran mentioned this issue Dec 13, 2017
Merged
encukou pushed a commit that referenced this issue Dec 13, 2017
@tiran @encukou
Add pragma: no cover to avoid spurious cov changes
cf24a54 
"pragma: no cover" was added to two helper functions in slapdtest to
avoid spurious changes in coverage whenever slapd has a hick up.

#129
Closes: #127
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@encukou