Skip to content

result*() shouldn't raise on a message with non-successful result #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mistotebe opened this issue Apr 17, 2019 · 0 comments
Open

result*() shouldn't raise on a message with non-successful result #278

mistotebe opened this issue Apr 17, 2019 · 0 comments

Comments

@mistotebe
Copy link
Contributor

Issue description:

I'm writing an asyncio wrapper (https://gist.github.com/mistotebe/7bbc48ce20c8dc82f6885b370353be60) and got hit by the issues #177 and #208. And there is no way to avoid an exception to be raised (it is coming from the C code).

My proposal is to allow the actual message to be returned from result* methods and issue exceptions from the *_s methods where appropriate.

Steps to reproduce:

Have the server return an error result to a request, call client.result*() to read it.

Operating system:

Any. (Debian buster)

Python version:

Any. (3.7.3rc1)

python-ldap version:

Any? (3.1.0)
mistotebe added a commit to mistotebe/python-ldap that referenced this issue May 2, 2019
@mistotebe
WIP on python-ldap#278
0f83de6 
Would be nice if result4 returned the operation result as well (but for
that we'd need to expose the result codes too, at the moment all of them
are just exceptions that can't even be converted to ints).
mistotebe added a commit to mistotebe/python-ldap that referenced this issue May 2, 2019
@mistotebe
WIP on python-ldap#278
cc1a709 
Would be nice if result4 returned the operation result as well (but for
that we'd need to expose the result codes too, at the moment all of them
are just exceptions that can't even be converted to ints).
mistotebe added a commit to mistotebe/python-ldap that referenced this issue May 2, 2019
@mistotebe
WIP on python-ldap#278
b5dd6b9 
Would be nice if result4 returned the operation result as well (but for
that we'd need to expose the result codes too, at the moment all of them
are just exceptions that can't even be converted to ints).
mistotebe added a commit to mistotebe/python-ldap that referenced this issue May 2, 2019
@mistotebe
WIP on python-ldap#278
0e13420 
Would be nice if result4 returned the operation result as well (but for
that we'd need to expose the result codes too, at the moment all of them
are just exceptions that can't even be converted to ints).
mistotebe added a commit to mistotebe/python-ldap that referenced this issue Apr 30, 2020
@mistotebe
WIP on python-ldap#278
18894ce 
Would be nice if result4 returned the operation result as well (but for
that we'd need to expose the result codes too, at the moment all of them
are just exceptions that can't even be converted to ints).
mistotebe added a commit to mistotebe/python-ldap that referenced this issue Apr 30, 2020
@mistotebe
WIP on python-ldap#278
1652a87 
Would be nice if result4 returned the operation result as well (but for
that we'd need to expose the result codes too, at the moment all of them
are just exceptions that can't even be converted to ints).
mistotebe added a commit to mistotebe/python-ldap that referenced this issue Apr 30, 2020
@mistotebe
WIP on python-ldap#278
82f050b 
Would be nice if result4 returned the operation result as well (but for
that we'd need to expose the result codes too, at the moment all of them
are just exceptions that can't even be converted to ints).
mistotebe added a commit to mistotebe/python-ldap that referenced this issue Apr 30, 2020
@mistotebe
WIP on python-ldap#278
8492b16 
Would be nice if result4 returned the operation result as well (but for
that we'd need to expose the result codes too, at the moment all of them
are just exceptions that can't even be converted to ints).
mistotebe added a commit to mistotebe/python-ldap that referenced this issue May 7, 2020
@mistotebe
WIP on python-ldap#278
bb3b287 
Would be nice if result4 returned the operation result as well (but for
that we'd need to expose the result codes too, at the moment all of them
are just exceptions that can't even be converted to ints).
mistotebe added a commit to mistotebe/python-ldap that referenced this issue May 18, 2020
@mistotebe
WIP on python-ldap#278
e4ff75b 
Would be nice if result4 returned the operation result as well (but for
that we'd need to expose the result codes too, at the moment all of them
are just exceptions that can't even be converted to ints).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mistotebe