Skip to content

Replace raw type values in syncrepl.py with the name values #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
quanah opened this issue Apr 22, 2024 · 0 comments
Closed

Replace raw type values in syncrepl.py with the name values #565

quanah opened this issue Apr 22, 2024 · 0 comments

Comments

@quanah
Copy link
Contributor

quanah commented Apr 22, 2024

If you found a bug in python-ldap, or would request a new feature,
this is the place to let us know.

Please describe the issue and your environment here.

Issue description:

The code in syncrepl.py uses raw type values (100, 101, 121) instead of their corresponding name values which makes the code less legible than necessary

Steps to reproduce:

Inspect code
quanah added a commit to quanah/python-ldap that referenced this issue Apr 22, 2024
@quanah
Fixes python-ldap#565 - Use name values instead of raw decimal
b8838a3 
Use the name values for result types in syncrepl.py rather than the raw decimal values.

Signed-off-by: Quanah Gibson-Mount <quanah@openldap.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@quanah