Skip to content

[PoC] Fix stacklevel for warning #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Dec 6, 2017

Closes: #108
Signed-off-by: Christian Heimes cheimes@redhat.com

@codecov
Copy link

codecov bot commented Dec 6, 2017

Codecov Report

Merging #109 into master will increase coverage by 0.13%.
The diff coverage is 68%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage    68.7%   68.83%   +0.13%     
==========================================
  Files          49       49              
  Lines        4694     4682      -12     
  Branches      789      787       -2     
==========================================
- Hits         3225     3223       -2     
+ Misses       1117     1108       -9     
+ Partials      352      351       -1
Impacted Files Coverage Δ
Lib/ldap/ldapobject.py 67.24% <68%> (+0.43%) ⬆️
Lib/slapdtest/_slapdtest.py 82.88% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc7a3fe...cae8a2b. Read the comment docs.

Closes: python-ldap#108
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
Copy link
Member Author

tiran commented Dec 13, 2017

The approach is too complicated, let's do #128

@tiran tiran closed this Dec 13, 2017
@tiran tiran deleted the warn_stacklevel branch December 13, 2017 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant