Auto-detect stacklevel for bytes warning #120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: python-ldap#108 Signed-off-by: Christian Heimes <cheimes@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 68.87% 69.04% +0.17%
==========================================
Files 49 49
Lines 4694 4688 -6
Branches 789 788 -1
==========================================
+ Hits 3233 3237 +4
+ Misses 1111 1102 -9
+ Partials 350 349 -1
Continue to review full report at Codecov.
|
|
Fixed in #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to PR #109. I'm walking up the stack frames to find the first frame that is outside the python-ldap's ldapobject module.
Closes: #108
Signed-off-by: Christian Heimes cheimes@redhat.com