More bytesmode #152
Merged
More bytesmode #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a hack, but looks reasonable. I was considering doing something similar :) I'll do a review next week. |
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
+ Coverage 69.34% 69.56% +0.21%
==========================================
Files 49 49
Lines 4707 4731 +24
Branches 808 817 +9
==========================================
+ Hits 3264 3291 +27
+ Misses 1088 1085 -3
Partials 355 355
Continue to review full report at Codecov.
|
Schema attribute names must be text in Python 2, too. Otherwise read_subschemasubentry_s() fails with bytes error. Signed-off-by: Christian Heimes <cheimes@redhat.com>
Tests marked with expected failure are currently affected by bug python-ldap#147. See: python-ldap#147 Signed-off-by: Christian Heimes <cheimes@redhat.com>
Several default arguments are not compatible with bytes mode. Default to bytes in bytes mode. See: python-ldap#147 Signed-off-by: Christian Heimes <cheimes@redhat.com>
Signed-off-by: Christian Heimes <cheimes@redhat.com>
b5caf78 to
f8f8c9c
Compare
encukou
reviewed
Jan 10, 2018
|
|
||
| ``filterstr=None`` is equivalent to ``filterstr='(objectClass=*)'``. | ||
|
|
There was a problem hiding this comment.
Looks good; the only nitpick I found is to say equivalent instead of equal here.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #147