Add bytes_strictness to allow configuring behavior on bytes/text mismatch #171
Conversation
5ce6e74 to
1b17e85
Compare
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=========================================
- Coverage 69.61% 69.51% -0.1%
=========================================
Files 49 49
Lines 4732 4740 +8
Branches 817 820 +3
=========================================
+ Hits 3294 3295 +1
- Misses 1084 1088 +4
- Partials 354 357 +3
Continue to review full report at Codecov.
|
|
@tiran, whenever you're ready, could you take a look? |
|
@encukou Next week after DevConf CZ. |
| if bytes_mode: | ||
| raise ValueError("bytes_mode is *not* supported under Python 3.") | ||
| bytes_mode = False | ||
| bytes_strictness = 'error' |
There was a problem hiding this comment.
Maybe raise an exception when bytes_strictness argument is neither 'error' nor None?
| is a subclass of :class:`BytesWarning` designed to be easily | ||
| :ref:`filtered out <filter-bytes-warning>` if needed. | ||
| ``bytes_strictness='error'`` (default if ``bytes_mode`` is specified): | ||
| A ``TypeError`` is raised. |
There was a problem hiding this comment.
We should spell out the behavior in form of an example and list affected attributes
If bytes_mode is True and a text string is encountered, then a TypeError is raised. If bytes_mode is False...
Bytes mode applies to:
dnargumentattrargumentnewrdnargument forrenamewhoandcredforbinduser,oldpwandnewpwforpasswdbase,filterstrandattrlistmembers forsearch*mod_type(2nd argument) of modlist member foradd*,modify*
There was a problem hiding this comment.
I linked to text mode from those arguments. Does that look good?
|
Should document that the strictness option only applies to py2; on py3 it's ignored. It's done this way for py2/py3 single-source compatibility. |
Thi is done to better support programs compatible with both py2 and py3.
|
@tiran, do you think you'll find some time to review? |
|
@tiran, can you get to a review by end of this week? |
There was a problem hiding this comment.
Ship it!
We can address https://github.com/python-ldap/python-ldap/pull/171/files#r164738710 another time
See #166 for initial discussion, or the changed docs for what is added.
I've used
bytes_strictnessinstead ofbytes_warnings, since warnings is just one of the possible behaviors. The new name isn't perfect either, though.