Skip to content

Make SlapdObject a context manager #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2018
Merged

Make SlapdObject a context manager #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55c96b9
Make SlapdObject a context manager
jdufresne Mar 30, 2018
ca705aa
Add versionchanged entry in slapdtest docs about context manager
encukou Apr 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Lib/slapdtest/_slapdtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,14 @@ class SlapdObject(object):

When a reference to an instance of this class is lost, the slapd
server is shut down.

An instance can be used as a context manager. When exiting the context
manager, the slapd server is shut down and the temporary data store is
removed.

.. versionchanged:: 3.1

Added context manager functionality
"""
slapd_conf_template = SLAPD_CONF_TEMPLATE
database = 'mdb'
Expand Down Expand Up @@ -553,6 +561,13 @@ def ldapdelete(self, dn, recursive=False, extra_args=None):
extra_args.append(dn)
self._cli_popen(self.PATH_LDAPDELETE, extra_args=extra_args)

def __enter__(self):
self.start()
return self

def __exit__(self, exc_type, exc_value, traceback):
self.stop()


class SlapdTestCase(unittest.TestCase):
"""
Expand Down
18 changes: 18 additions & 0 deletions Tests/t_slapdobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import unittest

import slapdtest


class TestSlapdObject(unittest.TestCase):
def test_context_manager(self):
with slapdtest.SlapdObject() as server:
self.assertIsNotNone(server._proc)
self.assertIsNone(server._proc)

def test_context_manager_after_start(self):
server = slapdtest.SlapdObject()
server.start()
self.assertIsNotNone(server._proc)
with server:
self.assertIsNotNone(server._proc)
self.assertIsNone(server._proc)