Make initialize() pass extra keyword arguments to LDAPObject #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use signatures and doc from the code (and docstrings) using Sphinx autodoc.
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
===========================================
+ Coverage 58.1% 70.93% +12.82%
===========================================
Files 49 49
Lines 5907 4816 -1091
Branches 813 812 -1
===========================================
- Hits 3432 3416 -16
+ Misses 2157 1066 -1091
- Partials 318 334 +16
Continue to review full report at Codecov.
|
|
@tiran, could you find some time for a review? |
tiran
requested changes
Jan 3, 2019
Lib/ldap/ldapobject.py
Outdated
| @@ -76,7 +76,9 @@ class NO_UNIQUE_ENTRY(ldap.NO_SUCH_OBJECT): | |||
|
|
|||
| class SimpleLDAPObject: | |||
| """ | |||
| Drop-in wrapper class around _ldap.LDAPObject | |||
| This basic class wraps all methods of the underlying C API object. | |||
There was a problem hiding this comment.
Please also indent the leading and trailing """.
There was a problem hiding this comment.
That would mean re-indenting the entire class, which is too much for this PR. So I un-indented the contents instead.
Lib/ldap/ldapobject.py
Outdated
| (e.g. in Lotus Domino) which drop connections very often making | ||
| it impossible to have a long-lasting control flow in the | ||
| application. | ||
| :py:class:`SimpleLDAPObject` subclass whose synchronous request methods |
There was a problem hiding this comment.
Please also indent the leading and trailing """.
tiran
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #249
Also, documentation for these should now match the code.