Codecov Report

Merging #262 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   71.38%   71.42%   +0.04%     
==========================================
  Files          49       49              
  Lines        4837     4837              
  Branches      808      808              
==========================================
+ Hits         3453     3455       +2     
+ Misses       1050     1048       -2     
  Partials      334      334              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8fd053...e2bcd62. Read the comment docs.

Is there any chance of getting this pull request merged? We're using this in production and are forced to use a patched build of python-ldap because of this.

I was sorry to see that a new version has been released without any of the pull requests opened for the project being merged. I think this is really discouraging for 3rd party contributors...

Indeed, there's a shortage of contributor time. Sorry for that!
Would you like to help by doing reviews of the outstanding pull requests?

The last release had quite a few pull requests merged. Sorry that yours was one of the ones that didn't make it – when the critical bugfix was reviewed, I took everything that was merged until then.

Indeed, there's a shortage of contributor time.

Still the case.

This PR is missing tests and documentation. Would you care to add them?

I've updated the patch with docs and tests. Also, I've found out that this would probably fix #177.

Thank you for the update, and apologies again for not finding time to review the pull request.
@mistotebe found a more robust solution to this problem in #288, so #/177 is now solved!

Compared to this pull request, the key is named msgid rather than msg_id. I hope that is not too much trouble.

I would still like to merge the tests and documentation from this pull request, though. I will rebase, update and merge it.

Thanks for finally merging a solution for this.
I'll update our code to use msgid once python-ldap 3.3 is released.