Tox: replace setup.py test with unittest discover #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 71.38% 71.42% +0.03%
==========================================
Files 49 49
Lines 4837 4714 -123
Branches 808 785 -23
==========================================
- Hits 3453 3367 -86
+ Misses 1050 1027 -23
+ Partials 334 320 -14
Continue to review full report at Codecov.
|
|
The changeset breaks coverage and codecov. Back to the drawing board! |
478da41 to
da85e98
Compare
encukou
reviewed
Jun 5, 2020
|
Let's try coverage 5.1 |
setup.py test is deprecated and causes issues with testing our code. There are cases where the wrong shared library is picked up. The ``unittest discover`` approach avoids building the extension twice. Install coverage < 5.0 to work around a problem with sqlite. python-ldap should move to pytest eventually. Fixes: python-ldap#326 Signed-off-by: Christian Heimes <cheimes@redhat.com>
|
For some reason, Travis CI is not reporting results. But the build for 68bfc62 passed: https://travis-ci.org/github/python-ldap/python-ldap/builds/695111114 |
encukou
approved these changes
Jun 5, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py test is deprecated and causes issues with testing our code.
There are cases where the wrong shared library is picked up.
The
unittest discoverapproach avoids building the extension twice.python-ldap should move to pytest eventually.
Fixes: #326
Signed-off-by: Christian Heimes cheimes@redhat.com