Skip to content

Limit coverage version to <5.0 again to work around CI issues #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

encukou
Copy link
Member

@encukou encukou commented Jun 5, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #346 into master will increase coverage by 0.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   70.47%   71.30%   +0.83%     
==========================================
  Files          50       50              
  Lines        4792     4796       +4     
  Branches      802      802              
==========================================
+ Hits         3377     3420      +43     
+ Misses       1071     1046      -25     
+ Partials      344      330      -14     
Impacted Files Coverage Δ
Modules/constants.c 53.50% <0.00%> (-0.81%) ⬇️
Lib/ldap/cidict.py 96.49% <0.00%> (+0.06%) ⬆️
Lib/slapdtest/_slapdtest.py 85.31% <0.00%> (+0.26%) ⬆️
Lib/ldap/ldapobject.py 80.23% <0.00%> (+4.45%) ⬆️
Lib/ldap/sasl.py 86.11% <0.00%> (+5.55%) ⬆️
Lib/ldap/__init__.py 90.38% <0.00%> (+13.46%) ⬆️
Lib/ldap/functions.py 97.50% <0.00%> (+17.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5996ec...6c5de90. Read the comment docs.

@tiran tiran merged commit 39ea8e5 into python-ldap:master Jun 5, 2020
@encukou encukou deleted the coverage4 branch June 6, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants