Syncrepl fails to parse SyncInfoMessage when the message is a syncIdSet #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the SyncInfoMessage parser used a for loop to test for the presence of each named choice with with the structure. However, because refreshDelete and refreshPresent both are able to be fully resolved as defaults, and due to how pyasn1 accesses named types, it was not checking the choice tag, and would return a fully populated refreshDelete to the caller instead. This fixes the parser to always return the inner component, and retrieves the name based on the current choice of the tagged item. Author: William Brown <william@blackhats.net.au>
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 71.30% 71.34% +0.03%
==========================================
Files 50 50
Lines 4796 4795 -1
Branches 802 801 -1
==========================================
+ Hits 3420 3421 +1
+ Misses 1045 1043 -2
Partials 331 331
Continue to review full report at Codecov.
|
|
Thanks for the fix, William. Do you have a reproducer bug for the test suite? |
|
Added a test case for you. |
tiran
requested changes
Jun 9, 2020
Good suggestion! Thanks! Co-authored-by: Christian Heimes <christian@python.org>
|
Thanks mate, appreciate the suggestion! I was a bit focused on the logic not the mesagge decode, but more coverage helps and helps guarantee correctness. Thanks! |
tiran
approved these changes
Jun 9, 2020
|
@encukou This fix is a candidate for 3.3.0 release, too. |
liuyangxy
pushed a commit
to fedora-riscv/python-ldap
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the SyncInfoMessage parser used a for loop to test for the
presence of each named choice with with the structure. However, because
refreshDelete and refreshPresent both are able to be fully resolved
as defaults, and due to how pyasn1 accesses named types, it was not
checking the choice tag, and would return a fully populated refreshDelete
to the caller instead.
This fixes the parser to always return the inner component, and retrieves
the name based on the current choice of the tagged item.
Author: William Brown william@blackhats.net.au