Prepare auto-formatting with black #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes autopep8 and prepares configuration for import sorter isort. Signed-off-by: Christian Heimes <cheimes@redhat.com>
encukou
reviewed
Jun 29, 2020
| @@ -0,0 +1,8 @@ | |||
| [tool.black] | |||
| line-length = 88 | |||
There was a problem hiding this comment.
If this needs to be specified, why not stick to PEP 8?
There was a problem hiding this comment.
88 is the default line length for black. I'm mentioning 88 here to make the line length setting explicit.
|
Overall, I must say I don't agree with the choices Black enforces. I won't enjoy reviewing these changes. I would like to step down as the main maintainer of python-ldap before this goes in. |
|
Personally, I like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes autopep8 and prepares configuration for import sorter
isort.
Signed-off-by: Christian Heimes cheimes@redhat.com