Skip to content

SlapdObject directory based configuration method, and slapadd implementation #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

azmeuk
Copy link
Contributor

@azmeuk azmeuk commented Oct 1, 2020

Fixes #373
Fixes #377

This OpenLDAP documentation tells:

The older style slapd.conf(5) file is still supported, but its use is deprecated and support for it will be withdrawn in a future OpenLDAP release. Configuring slapd(8) via slapd.conf(5) is described in the next chapter.

This patch:

  • makes slapd use the new directory based configuration method;
  • implements the SlapdObject.slapadd method;
  • tests the usage of SlapdObject.slapadd method by adding a custom schema;
  • allow users to redefine SlapdObject.openldap_schema_files so they can load custom schemas at startup.

@azmeuk
Copy link
Contributor Author

azmeuk commented Oct 19, 2020

@encukou Can I do something to help you reviewing this patch? Should we summon other contributors?

Copy link
Contributor

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
After @encukou, @tiran, or another contributor will take a look and give their review, we can push it.

@encukou
Copy link
Member

encukou commented Oct 22, 2020

Should we summon other contributors?

Yes. My role here is mostly administrative.
@tiran, if you don't have any objections, I'll merge.

@encukou encukou merged commit 7dc1e62 into python-ldap:master Oct 29, 2020
@azmeuk azmeuk mentioned this pull request Nov 10, 2020
francoisfreitag added a commit to francoisfreitag/django-auth-ldap that referenced this pull request Dec 16, 2021
Before python-ldap/python-ldap#382, the schema
files were included in slapd.conf, so the additional schema files were
listed.

The release python-ldap==3.4.0 is the first with
python-ldap/python-ldap#382, which migrates to
the modern configuration for SlapdObject. The LDIF files should now be
used to configure slapd.
francoisfreitag added a commit to francoisfreitag/django-auth-ldap that referenced this pull request Dec 16, 2021
Before python-ldap/python-ldap#382, the schema
files were included in slapd.conf, so the additional schema files were
listed.

The release python-ldap==3.4.0 is the first with
python-ldap/python-ldap#382, which migrates to
the modern configuration for SlapdObject. The LDIF files should now be
used to configure slapd.
francoisfreitag added a commit to django-auth-ldap/django-auth-ldap that referenced this pull request Dec 16, 2021
Before python-ldap/python-ldap#382, the schema
files were included in slapd.conf, so the additional schema files were
listed.

The release python-ldap==3.4.0 is the first with
python-ldap/python-ldap#382, which migrates to
the modern configuration for SlapdObject. The LDIF files should now be
used to configure slapd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SlapdObject configuration methods Add a custom schema to SlapdObject with a slapadd method?
3 participants