support OPT_X_TLS_PEERCERT #401
Conversation
df06b20 to
e73ab55
Compare
| @@ -399,7 +401,20 @@ LDAP_get_option(LDAPObject *self, int option) | |||
| v = LDAPControls_to_List(lcs); | |||
| ldap_controls_free(lcs); | |||
| return v; | |||
|
|
|||
| #ifdef LDAP_OPT_X_TLS_PEERCERT | |||
| case LDAP_OPT_X_TLS_PEERCERT: | |||
There was a problem hiding this comment.
ah this is only in openldap >=2.5.0
|
Is there a way to get CI to test against the openldap alpha releases? |
Not really, but you add a test that's skipped based on the libldap version, a manual test should be enough. |
|
I don't know how to set up the openldap alpha manually either |
|
OpenLDAP 2.5 is the official current release, 2.4 is EOL, python-ldap should likely figure out how to support the current release. |
|
Is there anything in python-ldap that doesn't work with OpenLDAP 2.5? Which distros ship it? The major ones, including Arch, seem to be on 2.4 – that doesn't look EOL to me. |
From the OpenLDAP project perspective, it is end of life. What distributions do is not something the OpenLDAP project tracks. |
Do you have any source for that info? The 2.4.59 release announcement from a few months ago doesn't mention the 2.4.x line being EOL. |
Well, given I'm the release manager for the OpenLDAP project, I'd say that's a pretty decent source of info. We have no plans on any further 2.4 releases unless a major CVE crops up. Our current focus in on getting OpenLDAP 2.6 out in the next quarter. |
|
Closing in favour of #427 |
No description provided.