Skip to content

Process missing libldap options #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 20, 2022
Merged

Conversation

mistotebe
Copy link
Contributor

No description provided.

@mistotebe mistotebe force-pushed the options branch 2 times, most recently from bd5772a to 9487bd0 Compare February 14, 2022 13:38
@mistotebe
Copy link
Contributor Author

I've integrated #427 with my comment resolved. Due to changes to the generated header, I've also included #458, don't know how to mark it as a dependency.

droideck
droideck previously approved these changes Mar 27, 2022
Copy link
Contributor

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the minor issue, looks good!

Get peer's certificate as binary ASN.1 data structure (not supported)
Get peer's certificate as binary ASN.1 data structure (DER)

.. versionadded:: 3.4.0
Copy link
Contributor

@droideck droideck Mar 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand our release process correctly, the right release version will be 3.4.1 here.

3.4.0 is already released and it doesn't have OPT_X_TLS_PEERCERT option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, should we use a placeholder in these and leave replacing that to the release process?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that, but I think it makes more sense to plan the changes because if we use a placeholder, then when we have the next release, it will be dynamically filled with some amount of fixes/features, and it'll feel too unpredictable.

So I think it'll be more natural to triage the issues we work on, assign the milestone, and then when we have the next release, we do the tagging, etc.
Also, this way we'll be able to plan major changes ahead of time (like the removal of Python 2 was planned for 3.4.0).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this, also removed some deprecated options and constants according to #67. I guess if everything is OK, we'll get OpenLDAP 2.5 support and that might warrant pushing out 3.4.1, unless we want some other things in there too, creating a milestone for tracking.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that OpenLDAP 2.5 support is already a solid reason to release. So as it's done, I think, we can review what has changed since 3.4.0 release and push out 3.4.1 as you suggested. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've merged this. Could you review what other issues should go into 3.4.1 and add them? Also review pending PRs, I think I'll add a fix for #448 into that shortly.

Copy link
Contributor

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run a few tests and it looks great!
The code looks good too! Ack.

@mistotebe mistotebe merged commit 5cac85a into python-ldap:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants