feat(ldap.dn): Add support for different formats in ldap.dn2str() via flags
#466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6948a13 to
f25fa60
Compare
|
@spaceone hi! |
|
Overall, I think it'll be nice to have the feature. |
|
I agree, getting better DN handling would be nice. |
spaceone
commented
Sep 28, 2022
Lib/ldap/dn.py
Outdated
Comment on lines
60
to
61
| #if not dn: | ||
| # return '' |
There was a problem hiding this comment.
libldap isn't too sure either, but allows it: https://git.openldap.org/openldap/openldap/-/blob/OPENLDAP_REL_ENG_2_6_3/libraries/libldap/getdn.c#L3021-3028
There was a problem hiding this comment.
Unless we want to make the distinction for None and make dn2str(None) is None, might be too much hassle though.
ldap.dn2str()ldap.dn2str() via flags
…` via flags In C `dn2str()` supports `flags` which works by providing one of `LDAP_DN_FORMAT_UFN`, `LDAP_DN_FORMAT_AD_CANONICAL`, `LDAP_DN_FORMAT_DCE`, `LDAP_DN_FORMAT_LDAPV3`. These symbols do exist in Python, but could not be used ultimately because the Python counterpart was pure Python and did not pass to `dn2str(3)`. Fix python-ldap#257
|
Performance comparison: C: Python: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C
dn2str()supportsflagswhich works by providingLDAP_DN_FORMAT_UFN,LDAP_DN_FORMAT_AD_CANONICAL, ….These symbols do exist in Python, but could not be used ultimately because the Python counterpart was pure Python and did not pass to
dn2str(3).Fix #257