Add retry on EINTR. #527
Open
Add retry on EINTR. #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try and fix issue python-ldap#242 by adding a retry on EINTR and a sleep before attempting to do so.
similar to original function to pass tests.
|
Apologies for the delay, pretty inexperienced with python. Made some changes to fix tests. |
|
doesn't it already work when you use |
|
I tested with ldap.ldapobject.ReconnectLDAPObject and unfortunately the interrupts still occur and don't seem to retry. The bind action seems to work but a call to say modify a group will throw the error. |
|
Is setting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try and fix issue #242 by adding a retry on EINTR and a sleep before attempting to do so. This is based off of #291.
We happen to come across a few instances of EINTR in our usage every day and would like to add a single retry since it seems all further LDAP calls are successful. Only kept it to a single retry for now, though I could be convinced to raise it.