Skip to content

Claim ownership of socket once we've passed it to libldap #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2023
Merged

Claim ownership of socket once we've passed it to libldap #544

merged 1 commit into from
Nov 2, 2023

Conversation

mistotebe
Copy link
Contributor

Per Python docs a socket object will close the underlying file descriptor on garbage collection and to use it elsewhere, one needs to call detach().

Fixes: #460
Closes: #543

tiran
tiran reviewed Nov 2, 2023
View reviewed changes
tiran
tiran approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thanks for digging into this rabbit hole.

@mistotebe mistotebe merged commit 1490e99 into python-ldap:main Nov 2, 2023
@ClydeByrdIII ClydeByrdIII mentioned this pull request Aug 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests/t_ldapobject.py fails on pypy3 CI run
2 participants
@mistotebe @tiran