refactor: Port LDAP_Type to heap type #546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
539cab7 to
b69c742
Compare
encukou
reviewed
Nov 6, 2023
The `LDAP` type has been converted from a static type to a heap type.
The limited API does not support static types.
Heap types behave more closely like Python classes. They are allocated
on the heap and reference counted. Instances have a strong reference to
their type and must use GC protocol to track this reference.
The LDAP type can no longer be instantiated by Python code. This was
never supported and resulted in an invalid LDAP connection. Code like
`type(_ldap.initialize(""))()" now fails with a `TypeError`.
See: python-ldap#540
Signed-off-by: Christian Heimes <cheimes@redhat.com>
b69c742 to
70303d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LDAPtype has been converted from a static type to a heap type. The limited API does not support static types.Heap types behave more closely like Python classes. They are allocated on the heap and reference counted. Instances have a strong reference to their type and must use GC protocol to track this reference.
The LDAP type can no longer be instantiated by Python code. This was never supported and resulted in an invalid LDAP connection. Code like
type(_ldap.initialize(""))()" now fails with aTypeError`.See: #540