Skip to content

Update Docs on installation requirements #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

Update Docs on installation requirements #548

merged 1 commit into from
Feb 27, 2024

Conversation

RafaelWO
Copy link
Contributor

This PR updates the documentation regarding the build prerequisites. Specifically, it separates build requirements from the ones needed for testing (for Debian).

I tested the build requirements with the following Dockerfile and it works.

FROM python:3.11

RUN apt-get update \
    && apt-get install -y build-essential ldap-utils \
    libldap2-dev libsasl2-dev \
    && rm -rf /var/lib/apt/lists/*
RUN pip install python-ldap==3.4.3

droideck
droideck approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelWO
Copy link
Contributor Author

@droideck Any idea why the checks are still pending ("Waiting for status to be reported")?

@droideck
Copy link
Contributor

@droideck Any idea why the checks are still pending ("Waiting for status to be reported")?

I think it could be because the PR is relatively old. Could you please rebase onto the main branch?

@RafaelWO
Update docs on installation requirements
940f648 
Separate building and testing requirements for Debian
@RafaelWO RafaelWO force-pushed the documentation/build-requirements branch from a77f8e4 to 940f648 Compare February 27, 2024 14:31
@RafaelWO
Copy link
Contributor Author

Could you please rebase onto the main branch?

Done! ✔️

@droideck droideck merged commit 06fdd3d into python-ldap:main Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droideck droideck droideck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RafaelWO @droideck