Skip to content

Add readthedocs configuration file #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mistotebe
Copy link
Contributor

Running without one has apparently been deprecated since September 2023.

BTW: RTD builds failing is probably unrelated (there is no indication of why they're failing to say for certain).

Running without one has apparently been deprecated since September 2023.
@mistotebe
Copy link
Contributor Author

An example failure for 3.4.4 that I just can't parse: https://readthedocs.org/api/v2/build/22604489.txt

Any ideas welcome, I'll also try later just in case it's something on RTD side they'll fix.

@droideck
Copy link
Contributor

An example failure for 3.4.4 that I just can't parse: https://readthedocs.org/api/v2/build/22604489.txt

Any ideas welcome, I'll also try later just in case it's something on RTD side they'll fix.

Did you have a change to test this PR on readthedocs project? (with a separate python-ldap-test project or something)?

If I understand correctly, the https://readthedocs.org/api/v2/build/22604489.txt failure is what we have without the PR, right?

@mistotebe
Copy link
Contributor Author

No haven't been able to test this at all, adapted the sample from https://blog.readthedocs.com/migrate-configuration-v2/ - which I just noticed has a deprecation timeline ending with a complete deprecation in the past so that might explain it.

Yeah, all failures are against current tags/main.

Copy link
Contributor

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've tested and it looks good for the latest version (which has your commit on it)!
https://readthedocs.org/projects/python-ldap-test/builds/22637292/

Ack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants