Add OpenLDAPSyncreplCookie class #571
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beb1513 to
3247211
Compare
droideck
previously approved these changes
Jul 30, 2024
Lib/ldap/syncrepl.py
Outdated
| if cookie: | ||
| self.update(cookie) | ||
|
|
||
| def _parse_csn(self, csn: str) -> List[str]: |
There was a problem hiding this comment.
I think the return value can be a tuple here and we can specify the number of elements right away: -> Tuple[str, str, str, str]
Also, it'll be nice to validate the tuple's len after the split.
There was a problem hiding this comment.
Good point, I'll adjust.
fe8d327 to
6a15068
Compare
6a15068 to
672779f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.