Skip to content

[WIP] Check and warn if OPT_X_TLS_NEWCTX is required #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] Check and warn if OPT_X_TLS_NEWCTX is required #64

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 30, 2017

See #55

Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran tiran force-pushed the tls_newctx branch 12 times, most recently from 1299d11 to afd80fd Compare December 5, 2017 16:27
@codecov
Copy link

codecov bot commented Dec 5, 2017 •
edited
Loading

Codecov Report

Merging #64 into master will increase coverage by 0.07%.
The diff coverage is 45%.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   68.87%   68.95%   +0.07%     
==========================================
  Files          49       49              
  Lines        4694     4712      +18     
  Branches      789      794       +5     
==========================================
+ Hits         3233     3249      +16     
  Misses       1111     1111              
- Partials      350      352       +2
Impacted Files Coverage Δ
Lib/ldap/constants.py 54.9% <ø> (ø) ⬆️
Modules/constants_generated.h 100% <ø> (ø) ⬆️
Lib/ldap/__init__.py 91.48% <100%> (ø) ⬆️
Lib/ldap/ldapobject.py 66.87% <100%> (+0.07%) ⬆️
Modules/LDAPObject.c 67.58% <29.16%> (-0.11%) ⬇️
Modules/constants.c 45.94% <33.33%> (-1.12%) ⬇️
Modules/options.c 81.53% <87.5%> (+1.05%) ⬆️
Lib/slapdtest/_slapdtest.py 82.88% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad72f2...f7597ce. Read the comment docs.

@tiran tiran force-pushed the tls_newctx branch 5 times, most recently from 1ff5c41 to 2522c4f Compare December 11, 2017 13:49
@tiran
Check and warn if OPT_X_TLS_NEWCTX is required
f7597ce 
Without OPT_X_TLS_NEWCTX, most settings TLS settings are not applied.

See python-ldap#55

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@encukou encukou modified the milestone: 3.1 Dec 15, 2017
@encukou encukou mentioned this pull request Mar 14, 2018
Merged
@encukou
Copy link
Member

encukou commented Sep 20, 2019

What's the progress here? Is it a dead end?

@tiran
Copy link
Member Author

tiran commented Jun 5, 2020

The documentation improvements are now merged. Let's not do the extra checks.

@tiran tiran closed this Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
correctness ease-of-use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiran @encukou