Skip to content

String byte format fix #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2019
Merged

String byte format fix #117

merged 1 commit into from
Mar 22, 2019

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Mar 7, 2019

Previously byte format had to be binary type on input and output of unmarshalling. Now it should be text type.

@p1c2u p1c2u force-pushed the fix/string-byte-format-fix branch from 408291c to 4f55111 Compare March 7, 2019 22:09
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #117 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   96.19%   95.92%   -0.27%     
==========================================
  Files          54       54              
  Lines        1444     1447       +3     
==========================================
- Hits         1389     1388       -1     
- Misses         55       59       +4
Impacted Files Coverage Δ
openapi_core/schema/schemas/models.py 94.23% <ø> (ø) ⬆️
openapi_core/schema/schemas/util.py 100% <100%> (ø) ⬆️
openapi_core/compat.py 55.55% <0%> (-44.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 395f68b...4f55111. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #117 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   96.31%   96.32%   +<.01%     
==========================================
  Files          54       54              
  Lines        1467     1470       +3     
==========================================
+ Hits         1413     1416       +3     
  Misses         54       54
Impacted Files Coverage Δ
openapi_core/schema/schemas/models.py 95.15% <ø> (ø) ⬆️
openapi_core/schema/schemas/util.py 95.83% <100%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c846b2e...f8e4e34. Read the comment docs.

@p1c2u p1c2u force-pushed the fix/string-byte-format-fix branch from 4f55111 to db607c9 Compare March 7, 2019 22:15
@p1c2u p1c2u force-pushed the fix/string-byte-format-fix branch from db607c9 to f8e4e34 Compare March 22, 2019 14:35
@p1c2u p1c2u merged commit e7fa45b into master Mar 22, 2019
@p1c2u p1c2u deleted the fix/string-byte-format-fix branch March 22, 2019 14:48
bjmc pushed a commit to bjmc/openapi-core that referenced this pull request Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant