Skip to content

Fix Requests.response factory #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

schunka
Copy link
Contributor

@schunka schunka commented Mar 25, 2020

Requests.response attribute raw is filelike object. During response validation it fails due to DeserializationError. It is the way the response.raw is treated like string or bytes object, witch it isn't.
content attribute on the other hand does exatctly wahat is expected.

@schunka schunka changed the title Update responses.py Fix Requests.response factory Mar 25, 2020
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #227 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   96.79%   96.79%           
=======================================
  Files         123      123           
  Lines        2403     2403           
=======================================
  Hits         2326     2326           
  Misses         77       77           
Impacted Files Coverage Δ
openapi_core/contrib/requests/responses.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ec335...926a17b. Read the comment docs.

Copy link
Collaborator

@p1c2u p1c2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @schunka . Thank you for the contribution. LGTM 👍

@p1c2u p1c2u merged commit 753637d into python-openapi:master Mar 27, 2020
@schunka schunka deleted the fix/requests-response-data branch March 29, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants