Skip to content

Spec path #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 2, 2021
Merged

Spec path #318

merged 8 commits into from
May 2, 2021

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Apr 27, 2021 •
edited
Loading

Introduces SpecPath which allow to get rid of schema package and reduces spec creation time.

Backward incompatibilities:

  • Spec replaced with SpecPath
  • create_spec shortcut returns SpecPath instead of Spec
  • removed Spec-related schema package
  • schema-related exceptions moved to top level exceptions module
  • readOnly/writeOnly invalid properties raise error (before were ommitted)

Other changes:

  • MediaTypeDeserializersFactory.create expects mimetype string instead of media_type
  • MediaTypeFinder.find returns media_type, mimetype tuple instead of just media_type

@p1c2u p1c2u force-pushed the feature/spec-path branch from 7f8d9f3 to 0b23d66 Compare April 28, 2021 22:07
@codecov
Copy link

codecov bot commented Apr 28, 2021 •
edited
Loading

Codecov Report

Merging #318 (bbeb43c) into master (b79c494) will decrease coverage by 0.69%.
The diff coverage is 98.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   96.88%   96.18%   -0.70%     
==========================================
  Files         129       80      -49     
  Lines        2534     1548     -986     
==========================================
- Hits         2455     1489     -966     
+ Misses         79       59      -20
Impacted Files Coverage Δ
openapi_core/validation/request/shortcuts.py 75.75% <ø> (-3.73%) ⬇️
openapi_core/exceptions.py 87.09% <86.20%> (-12.91%) ⬇️
openapi_core/casting/schemas/casters.py 96.42% <100.00%> (+0.13%) ⬆️
openapi_core/casting/schemas/factories.py 100.00% <100.00%> (ø)
...penapi_core/deserializing/media_types/factories.py 100.00% <100.00%> (ø)
...api_core/deserializing/parameters/deserializers.py 100.00% <100.00%> (ø)
openapi_core/deserializing/parameters/factories.py 100.00% <100.00%> (ø)
openapi_core/schema/parameters.py 100.00% <100.00%> (ø)
openapi_core/schema/schemas.py 100.00% <100.00%> (ø)
openapi_core/schema/servers.py 100.00% <100.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b79c494...bbeb43c. Read the comment docs.

@p1c2u p1c2u force-pushed the feature/spec-path branch 5 times, most recently from 23426bf to 90d035f Compare May 2, 2021 20:32
@p1c2u p1c2u force-pushed the feature/spec-path branch from 90d035f to bbeb43c Compare May 2, 2021 21:08
@p1c2u p1c2u merged commit 05fd27f into master May 2, 2021
@p1c2u p1c2u deleted the feature/spec-path branch May 2, 2021 22:05
@bnavigator bnavigator mentioned this pull request Aug 16, 2021
Merged
@andersk andersk mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@p1c2u