Codecov Report

Merging #330 (f08a38b) into master (b801118) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files          80       80           
  Lines        2355     2355           
=======================================
  Hits         1671     1671           
  Misses        684      684           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b801118...f08a38b. Read the comment docs.

Hi @ashb thanks for the PR. I have few questions:

a bit of a hack

How not tacky way would look like?

support running tests against a non-editable install

I'm curious, why you need to run these tests?

recommended way as per https://docs.pytest.org/en/latest/explanation/goodpractices.html?highlight=tests%20outside#choosing-a-test-layout-import-rules

Do you mean "Tests outside application code" section or can you point me to exact paragraph?

Thanks in advance.

@p1c2u I haven't run in to this issue before with other pytest projects, so I'm not sure why I've hit it here (perhaps I have always just run with pip install -e . && pytest)

So there are two non-hacky ways we could do this. (I define hacky as having to tweak sys.path)

• Update docs and CI to do pip install -e . before running tests
• Convert to the src/ and tests/ layout which seems to be what Pytest recommends.

I don't have a strong preference either way. Do you?

Another way to do this is to use pytest-pythonpath and set

[tool:pytest]
pythonpath = .

in setup.cfg.

But always installing the package is still the better idea.

I think a lot of project these days don't have that issue since they tend to use nox or tox to run tests instead (they automatically reinstall the package into the test environment before invoking the test suite).

Thanks guys,

Python 2 support was dropped. Nothing stopping us now to update to pytest 6.

Convert to the src/ and tests/ layout which seems to be what Pytest recommends.

If so then we should go with the recommended way.

👍 I'll update this to use the recommended way.

@p1c2u Updated this PR.

I've left it with the same source layout, but added -e . in to requirements_dev.txt` so that it's installed that way.

Updated pytest with new poetry build system

@ashb @uranusjr thank you for the contribution