Use Poetry for dependency management and packaging #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
===========================================
- Coverage 96.72% 70.95% -25.78%
===========================================
Files 80 80
Lines 1743 2355 +612
===========================================
- Hits 1686 1671 -15
- Misses 57 684 +627
Continue to review full report at Codecov.
|
p1c2u
reviewed
Jul 1, 2021
|
Code coverage report went crazy dunno why |
|
@sisp thank you for the contribution |
|
@p1c2u I just noticed you didn't squash the commits of this PR before merging it. Was it intentional? |
|
Not intentional but that's okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Poetry for dependency management and packaging.
It addresses the first suggestion of #355. I think it's better to create separate PRs for the different improvements suggested in #355 instead of having one big PR. I've intentionally set most of the dependencies' version specifiers to
"*"to keep them as they are right now to not mix different steps of the migration.Let me know what you think. 🙂