Skip to content

Schema format accepts any value #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2018
Merged

Schema format accepts any value #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openapi_core/schema/schemas/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from six import iteritems

from openapi_core.extensions.models.factories import ModelFactory
from openapi_core.schema.schemas.enums import SchemaType, SchemaFormat
from openapi_core.schema.schemas.enums import SchemaType
from openapi_core.schema.schemas.exceptions import (
InvalidSchemaValue, UndefinedSchemaProperty, MissingSchemaProperty,
OpenAPISchemaError, NoOneOfSchema, MultipleOneOfSchema,
Expand All @@ -33,7 +33,7 @@ def __init__(
self.model = model
self.properties = properties and dict(properties) or {}
self.items = items
self.format = SchemaFormat(schema_format)
self.format = schema_format
self.required = required or []
self.default = default
self.nullable = nullable
Expand Down
1 change: 1 addition & 0 deletions tests/integration/data/v3.0/petstore.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ components:
properties:
name:
type: string
format: custom
TagList:
type: array
items:
Expand Down
6 changes: 3 additions & 3 deletions tests/integration/test_petstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def test_spec(self, spec, spec_dict):
assert type(parameter.schema) == Schema
assert parameter.schema.type.value ==\
schema_spec['type']
assert parameter.schema.format.value ==\
assert parameter.schema.format ==\
schema_spec.get('format')
assert parameter.schema.required == schema_spec.get(
'required', [])
Expand Down Expand Up @@ -171,7 +171,7 @@ def test_spec(self, spec, spec_dict):
assert type(media_type.schema) == Schema
assert media_type.schema.type.value ==\
schema_spec['type']
assert media_type.schema.format.value ==\
assert media_type.schema.format ==\
schema_spec.get('format')
assert media_type.schema.required == schema_spec.get(
'required', False)
Expand Down Expand Up @@ -690,7 +690,7 @@ def test_get_tags(self, spec, response_validator):
assert parameters == {}
assert body is None

data_json = []
data_json = ['cats', 'birds']
data = json.dumps(data_json)
response = MockResponse(data)

Expand Down