Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master     #46   +/-   ##
======================================
  Coverage    98.5%   98.5%           
======================================
  Files          52      52           
  Lines        1069    1069           
======================================
  Hits         1053    1053           
  Misses         16      16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f22b6a...f8e977c. Read the comment docs.

@HoverHell thanks for the contribution. That's big change. We need to cover it with tests.

That's big change. We need to cover it with tests.

Were there tests previously covering this?

What I did is, I tried to use a openapi_core.validation.request.validators.RequestValidator over a openapi_core.wrappers.mock.MockRequest, and found out that it raises an error when parsing the schema I was using. The schema, however, was valid (as validated, e.g., by editor.swagger.io).

In other words, it seemed as if this part never worked correctly. Or did it?

@HoverHell this part was never covered that's why it would be good to cover it

That's big change

Apparently it's not even a change as much as it's a fix.
Compare:
https://github.com/p1c2u/openapi-core/blob/4e1a61aaceaad026c74044ae2285f26f666521bd/tests/unit/schema/test_paramters.py#L25-L32

(also, that filename is mistyped)

Added tests for renames